Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to set hideElements cookie #1416

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Add function to set hideElements cookie #1416

merged 1 commit into from
Aug 27, 2024

Conversation

VladyslavTy
Copy link

Change description

Add helper function add_hide_elements_cookie_to_redirect to set the hideElements cookie if hide_elements parameter exist in redirect url. This should help to speed up hiding the elements from UI.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@github-actions GitHub Actions
Copy link

Checking git merge conflicts against https://github.com/openedx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 301
Current conflicts 304
Summary Adds 3 new conflicts. How can we do better?
New conflicting files with 'open-release/nutmeg.master' 
openedx/core/djangoapps/user_authn/views/login_form.py
Comparing with master
Benchmark conflicts with main 333
Current conflicts 336
Summary Adds 3 new conflicts. How can we do better?
New conflicting files with 'master' 
openedx/core/djangoapps/user_authn/views/login_form.py

@VladyslavTy VladyslavTy merged commit 1e3bded into main Aug 27, 2024
11 checks passed
@VladyslavTy VladyslavTy deleted the vladyslav/hide-html-elements-in-iframe branch August 27, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniilly daniilly daniilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VladyslavTy @daniilly